Open
Conversation
Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value. this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection
|
@thias this PR is now over a year old. Do you think there is a chance to get it merged? |
|
I ran Puppet with your updates and it did not fix: kernel.sem If I change the sed tab-replace line to substitue one space instead of two spaces, then only net.ipv4.route.flush is broken. I'll look into the code to see if there's more needed to fix the net.ipv4.route.flush. |
|
net.ipv4.route.flush isn't something that Puppet should manage because it's not a setting but more of a method to clear the routing table (and hence causes a change). I've submitted schlitzered#1 to THIS pull request to fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value.
this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection